Reveal.js compatible slide id generation fixes history feature (#127) #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per our policy for merges: since this is a clear bugfix with backing test cases, I'm going to merge this even if it got no real comments or reviews |
obilodeau
added a commit
that referenced
this pull request
Oct 5, 2017
obilodeau
added a commit
to obilodeau/asciidoctor-reveal.js
that referenced
this pull request
Dec 12, 2018
Fixes asciidoctor#192 but also removes our workaround in asciidoctor#150. Test cases from asciidoctor#192 were added. Will impact links because the prepending of `_` is reintroduced on automatically generated links (Asciidoctor's behavior) so CHANGELOG will be explicit about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were still some problems with the id stripping regex. I created a more extensive test case and made sure to pass all tests.
References:
idwith special characters hakimel/reveal.js#1346