Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/asciidoctor-revealjs/converter.rb missing in 1.1.0 #172

Closed
Maurice-Mueller opened this issue Dec 30, 2017 · 3 comments
Closed

lib/asciidoctor-revealjs/converter.rb missing in 1.1.0 #172

Maurice-Mueller opened this issue Dec 30, 2017 · 3 comments
Assignees
@obilodeau
Labels
🐛 bug
Milestone
1.1.1

Comments

@Maurice-Mueller
Copy link

Today, I updated the gem from 1.0.4 to 1.1.0 . I get the following error now:

LoadError: cannot load such file -- .bundle/gems/ruby/2.4.0/gems/asciidoctor-revealjs-1.1.0/lib/asciidoctor-revealjs/converter
/.bundle/gems/ruby/2.4.0/gems/asciidoctor-revealjs-1.1.0/lib/asciidoctor-revealjs.rb:5:in `require_relative'
.bundle/gems/ruby/2.4.0/gems/asciidoctor-revealjs-1.1.0/lib/asciidoctor-revealjs.rb:5:in `<top (required)>'

Indeed, the file converter.rb is missing (it exists in 1.0.4 though).

Btw, something is also wrong with the official website: http://asciidoctor.org/docs/asciidoctor-revealjs/ (but I don't know, if this issue tracker is the right one - therefor, I didn't post an extra issue here).
@obilodeau obilodeau mentioned this issue Jan 1, 2018
Closed
@obilodeau
Copy link
Member

Wow, that's a pretty major mistake... Thanks for spotting! I'm going to release a 1.1.1 pretty soon then.

I filed the website issue here: asciidoctor/asciidoctor.org#759

@obilodeau obilodeau self-assigned this Jan 1, 2018
@obilodeau obilodeau changed the title [Bug] lib/asciidoctor-revealjs/converter.rb missing in 1.1.0 lib/asciidoctor-revealjs/converter.rb missing in 1.1.0 Jan 1, 2018
obilodeau added a commit to obilodeau/asciidoctor-reveal.js that referenced this issue Jan 1, 2018
@obilodeau
Adding converter.rb manually in gemspec. Fixes asciidoctor#172
ea17e99
@obilodeau obilodeau added this to the 1.1.1 milestone Jan 2, 2018
obilodeau added a commit that referenced this issue Jan 3, 2018
@obilodeau
Merge pull request #174 from obilodeau/packaging-fix
8ce78b7 
Adding converter.rb manually in gemspec. Fixes #172
@obilodeau
Copy link
Member

v1.1.1 has just been released!

@Maurice-Mueller
Copy link
Author

Maurice-Mueller commented Jan 4, 2018 •
edited

Yeah, it's working now :)

Thanks!

@dduportal dduportal mentioned this issue Jan 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obilodeau obilodeau

Labels
🐛 bug
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@obilodeau @Maurice-Mueller