Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role=right on image block's behavior could be improved #197

Closed
obilodeau opened this issue Jun 13, 2018 · 3 comments · Fixed by #213
Closed

role=right on image block's behavior could be improved #197

obilodeau opened this issue Jun 13, 2018 · 3 comments · Fixed by #213
Milestone

Comments

@obilodeau
Copy link
Member

Odd corner case I faced today. I usually do floating images this way:

== Slide Title

* Some
image:ego-market_paper_cover.png[role=right,width=200px]
* Points
* I'm trying
* To make

But in this case it is ugly:

imagespan-role-right

So trying various things, I think applying a role=right on an image block above the main slide content should do what I want (and be expected behavior for people familiar with html/css).

== Slide Title

image::ego-market_paper_cover.png[role=right,width=200px]

* Some
* Points
* I'm trying
* To make

This gives:

imageblock-role-right-now

But it's because there is no CSS instruction for role=right. I manually added one:

imageblock-role-right

This is I think what we want. Thoughts?

@mojavelinux
Copy link
Member

Yes, as much as possible we should control behavior using designated roles. That way, we maintain the right semantic abstraction.

@joaocmendonca
Copy link

Hey @obilodeau could you please post your custom css here? thx!

@obilodeau obilodeau added this to the 1.2.0 milestone Oct 16, 2018
@obilodeau
Copy link
Member Author

@joaocmendonca its:

.reveal div.right {
        float: right;
}

I'm looking at pushing this in the code right now.

obilodeau added a commit to obilodeau/asciidoctor-reveal.js that referenced this issue Oct 29, 2018
.

This is our first attempt at overriding CSS from reveal.js. Initial attempt is promising, we could backport a lot of AsciiDoc's features like tables and more.

Added a test case in examples/images.adoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants