Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: please add support for slide numbers #212

Closed
refaelsh opened this issue Oct 27, 2018 · 4 comments
Closed

Feature request: please add support for slide numbers #212

refaelsh opened this issue Oct 27, 2018 · 4 comments

Comments

@refaelsh
Copy link
Contributor

Hi all,

According to the AsciiDoctor RevealJS docs I can use this:

:revealjs_slideNumber: true

But, in RefaelJS docs, there are more options.
For example, I would like to do this:

:revealjs_slideNumber: c/t

Please add support for the above.

Thanks. Refael.

@obilodeau
Copy link
Member

Reveal.js 3.7.0 introduced many new configuration options which we don't support already. We have an issue open about it: #208.

I'm going to keep this one open because I might forget that slideNumber is no longer only a true / false toggle.

@obilodeau
Copy link
Member

Started working on this one. Tested many cases.

Quoting the parameter works to a certain extent because every new reveal.js feature starts working except that there is no way to disable slides numbers even with no attribute value or without even the :revealjs_slidenumber: being set.

This case will need a specific ruby helper where we will return quoted or unquoted values based on what the input is.

@obilodeau
Copy link
Member

Ok, I finally succeeded with the helper. I made a rookie mistake while debugging it. All I need is add more test cases and I'll have a PR soon.

obilodeau added a commit to obilodeau/asciidoctor-reveal.js that referenced this issue Feb 6, 2019
obilodeau added a commit that referenced this issue Feb 9, 2019
Added support for Reveal.js 3.7 slideNumber and showSlideNumber (#212)
@obilodeau
Copy link
Member

Fixed with the merge of #239 into master. Will be part of the upcoming 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants