Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to Asciidoctor.js' 1.5.9 (and matching Opal) #227

Closed
obilodeau opened this issue Nov 27, 2018 · 9 comments
Closed

Sync to Asciidoctor.js' 1.5.9 (and matching Opal) #227

obilodeau opened this issue Nov 27, 2018 · 9 comments
Milestone

Comments

@obilodeau
Copy link
Member

We post-poned #187. It means we specify asciidoctor.js' dependency still. A major release means we should sync with the latest code.

Opal is only required as a devDep, make sure it's not pulled-in in ruby environments if we specify a special version in the Gemfile.

@obilodeau obilodeau added this to the 2.0.0 milestone Nov 27, 2018
@obilodeau obilodeau changed the title Sync opal with Asciidoctor.js' 1.5.9 Sync to Asciidoctor.js' 1.5.9 (and matching Opal) Nov 27, 2018
@codecholeric
Copy link

I tried to combine https://github.com/eshepelyuk/asciidoctor-plantuml.js and asciidoctor-reveal.js and pretty much immediately ran into #187 (comment) (i.e. the opal-exception) which is a pretty nasty error message to debug for an end user 😉
I really haven't been able to figure this out so far, I've tried various dependency combinations, but as far as I can see the mentioned version asciidoctor.js@1.5.6 already has a dependency on opal-runtime@1.0.11 while asciidoctor-reveal.js@1.1.3 depends on asciidoctor.js@1.5.6-preview.4 which in turn depends on opal-runtime@0.11.0-integration8.
I don't know the versioning scheme of asciidoctor.js, but isn't it weird, that the last released version 1.1.3 of asciidoctor-reveal.js depends on a version 1.5.6-preview.4 of asciidoctor.js?
Do you have any hints how I could get this combination to work? Or am I missing something? (I would have just naively guessed, that I should be able to combine those two?)

@codecholeric
Copy link

BTW: If I force asciidoctor.js@1.5.6-preview.4 to be used, then asciidoctor-plantuml breaks within opal ☹️
So I guess those two versions are just incompatible...
Feels a little bit, like the plugin mechanism of asciidoctor.js should be improved somehow to not create a coupling via a specific version of a 3rd party lib...

@mojavelinux
Copy link
Member

That's literally what we're working on right now. There's a whole bunch of improvements coming to these integration layers, underpinned by a switch to semantic versioning. This extension will obviously be a good test of how it's coming along.

@codecholeric
Copy link

Cool, I'll watch out for improvements and test them. Without the plant-uml plugin it was smooth sailing before, will be cool to write reveal presentations in AsciiDoc with integrated PlantUML support 😄

@obilodeau
Copy link
Member Author

In the meantime you can try to use the Ruby toolkit: Asciidoctor + asciidoctor-diagram

@codecholeric
Copy link

Thanks @obilodeau, I've tried to get this to work with Gradle / JRuby, but I've failed as well with

Maybe I'll try the plain Ruby stack in the end (or just use RevealJS with Markdown and generate the PlantUML statically, even if it's not as convenient)

@obilodeau
Copy link
Member Author

obilodeau commented Jan 19, 2019 via email

@codecholeric
Copy link

With the new alpha version of the revealjs plugin I always either got something like "asciidoctorj is missing" or "can't add asciidoctorj as it is already present", no matter which combination I've tried.
With the second version I tinkered around for a while as well, but eventually stopped at

Passing through unknown backend: revealjs
(RuntimeError) Could not find a converter to handle transform: document

I really stripped the asciidoc down quite a lot and it should be the same as in the example, so I don't know (I saw an issue though in the example repo that had pretty much the same error message, don't know if it's related)
At the moment though I really need to create a presentation, so I'll just let it rest and look a little later, maybe when the asciidoctor-revealjs plugin comes out of alpha. For now I'm doing okay with markdown and statically rendered PlantUML...

@obilodeau
Copy link
Member Author

Yeah, I totally understand how time sensitive is preparing a presentation. Quick hacks are way better than a slide-deck with no diagrams on the stage 😆

Once the release will be done let's look at this again but in another ticket because this ticket got side-tracked here.

Getting back on track, I will sync to Asciidoctor.js 1.5.9 and matching Opal in a PR that should be submitted soon.

obilodeau added a commit that referenced this issue Feb 9, 2019
Javascript/Node: Sync with Asciidoctor.js 1.5.9 (fixes #227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants