Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing asciidoc / asciidoctor CSS for specific markup features #77

Open
3 of 5 tasks
obilodeau opened this issue Aug 25, 2016 · 12 comments · May be fixed by #451
Open
3 of 5 tasks

Missing asciidoc / asciidoctor CSS for specific markup features #77

obilodeau opened this issue Aug 25, 2016 · 12 comments · May be fixed by #451

Comments

@obilodeau
Copy link
Member

obilodeau commented Aug 25, 2016

For example, while asciidoctor supports the kbd:[F1] macro and we do the proper rendering in this back-end, since reveal.js doesn't have the CSS for that feature, the kbd macro does nothing on the visual output.

There are several things unsupported. Let's track them here:

@obilodeau
Copy link
Member Author

@mojavelinux how do you achieve this with bespoke? I don't see any CSS in the back-end.

@mojavelinux
Copy link
Member

@obilodeau I haven't covered all the CSS there yet either.

...but then again, if someone is using the kbd macro in a presentation, I really have to question why ;) I'd only find it acceptable for making a slideument. In which case, I might have a dedicated slideument theme.

@obilodeau obilodeau added this to the 1.2.0 milestone Aug 29, 2017
@obilodeau
Copy link
Member Author

This should now be really easy to fix. Just add relevant CSS there: https://github.com/asciidoctor/asciidoctor-reveal.js/blob/master/templates/asciidoctor_revealjs.css.slim

Pull Requests welcome!

@obilodeau
Copy link
Member Author

Added a ref to #276 in the top description.

@obilodeau obilodeau modified the milestones: 2.1.0, 3.0.0 Dec 10, 2019
@obilodeau obilodeau modified the milestones: 3.0.0, 3.1.0 Dec 10, 2019
@obilodeau
Copy link
Member Author

Tables and kbd macro are now supported. Updated tasks accordingly.

@slonopotamus
Copy link
Contributor

slonopotamus commented Feb 20, 2020

I want to use [.step] feature with something that is not actually a list, but just a sequence of statements.

If I'm not mistaken, [.step] currently only works on lists. So, I need a way to suppress list bullets.

In Asciidoctor, list bullet suppression is done using .unstyled role with following CSS: ul.unstyled{list-style-type:none;margin-left:0}. asciidoctor-reveal.js needs something like that.

@obilodeau
Copy link
Member Author

.unstyled

Thanks for reporting, I added it to the list at the top of this issue.

If I'm not mistaken, [.step] currently only works on lists. So, I need a way to suppress list bullets.

I don't think it should be the case since reveal.js supports fragments on different HTML items. Can you create a simple one-slide document demonstrating the issue and file a new issue with it please?

@slonopotamus
Copy link
Contributor

I don't think it should be the case since reveal.js supports fragments on different HTML items. Can you create a simple one-slide document demonstrating the issue and file a new issue with it please?

Sure, reported as #347.

@archiloque
Copy link
Contributor

I'd like to work on this issue but I need to know what visual result you'd want to achieve for the quotes.

For block quotes Asciidoctor displays only an opening quotation mark by default whereas reveal.js use nothing by default, and in its demo presentation they have an opening and a closing quotation mark (which is obtained by manually adding the quotation marks directly in the presentation content, it's not done with CSS):

Capture d’écran 2021-08-15 à 18 01 08

So what should asciidoctor-reveal.js do?

@ggrossetie
Copy link
Member

whereas reveal.js use nothing by default

I think that the default style provided by reveal.js is intentionally limited.

which is obtained by manually adding the quotation marks directly in the presentation content, it's not done with CSS

Yikes!

So what should asciidoctor-reveal.js do?

Not sure, I think the current output is decent.
Having said that, some font sizes are out of proportion but it might be a personal preference.

Still, I think it's important to provide a default style that looks great.
In my opinion, we should open a dedicated issue when we find an AsciiDoc/Asciidoctor feature that does not look great using the default style or when it has no visual hint.

@archiloque
Copy link
Contributor

In my opinion, we should open a dedicated issue when we find an AsciiDoc/Asciidoctor feature that does not look great using the default style or when it has no visual hint.

So for this issue I should just deal with the .unstyled case ?

@ggrossetie
Copy link
Member

So for this issue I should just deal with the .unstyled case ?

Yes 👍🏻

@archiloque archiloque linked a pull request Aug 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants