New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inline option on SVG images #453
Comments
I guess it misses conditions in this template to support this feature: asciidoctor-reveal.js/templates/image.html.slim Lines 15 to 19 in acb2247
For the sake of justifying the need behind this issue, with inline SVG it is possible to interact with the content of the SVG (eg. links, animation, scripting, etc). It is actually well explained in asciidoctor documentation. This feature would open new possibilities for even better presentations with asciidoctor-reveal.js 😀 |
Thanks for the issue. I was very confused I'd done something wrong. |
I totally agree, I think this is the mosst hurdle since I often mail my presentations - now I need to publish them all the time. Cheers, |
If someone stil encounters the issue, there is a possible hack done the following way
With these modifications, your image diagrams will all be inlined as direct SVG tags. This allow more interactivity, and ability to select individual SVG elements |
The relevant code in the built-in HTML5 converter: https://github.com/asciidoctor/asciidoctor/blob/a040b60300efaa0d75cc6a3b031241dbe7b5a864/lib/asciidoctor/converter/html5.rb#L1214-L1220 It seems that we can reuse |
Let's do it. If you need me to lend a hand, just call on me. |
@obilodeau @ggrossetie ping. Please merge the PR if u agree. |
When rendering asciidoc to plain html I can do e.g.
image::my-image.svg[opts=inline]
and it would inline the image into the resulting html.Is is possible to do so with
asciidoctor-reveal.js
.Cheers,
Mario :)
The text was updated successfully, but these errors were encountered: