Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Asciidoctor.js 2+ #254

Merged
merged 5 commits into from
Dec 10, 2019

Conversation

ggrossetie
Copy link
Member

Resolves #252

@obilodeau
Copy link
Member

I would prefer the unrelated changes to be split out.

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I haven't tested it yet.

It's cool to get rid of the need to have users create their own converter script but to also keep it as an option with a stable API.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ggrossetie
Copy link
Member Author

Could you be more specific ? All changes are related to the upgrade 🤔

@obilodeau
Copy link
Member

Could you be more specific ? All changes are related to the upgrade 🤔

I would prefer if the new syntax highlighter changes would be separate. I think this is what is breaking the tests right now.

@ggrossetie
Copy link
Member Author

I would prefer if the new syntax highlighter changes would be separate. I think this is what is breaking the tests right now.

A test was failing when running with Asciidoctor.js: https://github.com/asciidoctor/asciidoctor-reveal.js/blob/master/examples/source-pygments.adoc

But you're right, I'm using the following (which is working with Asciidoctor.js but failing with Asciidoctor):

- linkcss = node.attr? 'linkcss'

I think it should be - linkcss = attr? 'linkcss'

@ggrossetie ggrossetie force-pushed the issue-252-asciidoctor200 branch 2 times, most recently from 6f94920 to 84414e7 Compare April 17, 2019 06:25
@ggrossetie ggrossetie changed the title (wip) Upgrade to Asciidoctor.js 2.0.0-rc.2 Upgrade to Asciidoctor.js 2+ May 5, 2019
@johnjelinek
Copy link

Is this good to merge?

@ggrossetie
Copy link
Member Author

@obilodeau Please let me know if there's anything to fix before we can merge this upgrade 😃

templates/document.html.slim Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
npm/examples.js Show resolved Hide resolved
@obilodeau
Copy link
Member

I just did a new review. Only minor stuff, mostly documentation and comments.

README.adoc Show resolved Hide resolved
@ggrossetie
Copy link
Member Author

This pull request has too much changes, I will open pull request with smaller changes so it's easier for you to review.

README.adoc Show resolved Hide resolved
@ggrossetie
Copy link
Member Author

ggrossetie commented Dec 9, 2019

Now the documentation is Windows/PowerShell friendly.
I think it's ready to go.

@obilodeau obilodeau merged commit d1a01eb into asciidoctor:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Asciidoctor.js 2.0.0
3 participants