resolves #198 resolves docinfo head, header and footer #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
force-pushed
the
issue-198-docinfo
branch
from
82e6875
to
2da9cba
Compare
6 tasks
obilodeau
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
After a careful review of this, including reading bespoke's documentation and upstream API doc, I can say that I like it and it is going in.
I'll merge shortly but right before doing so, I'll add documentation and document the breaking behavior in the CHANGELOG.
Tests are skipped for now because there seems to be a problem with Asciidoctor-Doctest and docinfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/asciidoctor/asciidoctor-bespoke/blob/master/templates/slim/document.html.slim
I've added an example to make sure that it's working and here the result:
As suggested by @mojavelinux I've added a unique suffix but it's a breaking change because
docinfo.htmlwon't be resolved (it must be renamed todocinfo-revealjs.html)resolves #198