Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmetic improvements to callout lists #335

Merged
merged 4 commits into from
Feb 14, 2020
Merged

Cosmetic improvements to callout lists #335

merged 4 commits into from
Feb 14, 2020

Conversation

obilodeau
Copy link
Member

Merge after #334

  • Imported styles from Asciidoctor
  • Required an override for bottom border
  • Disabled upstream style with a negative margin causing overlap if .stretched class is used

@obilodeau obilodeau added this to the 4.0.0 milestone Feb 11, 2020
ggrossetie
ggrossetie approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 👍

@obilodeau obilodeau merged commit fbb1ea8 into asciidoctor:master Feb 14, 2020
@obilodeau obilodeau deleted the callout-list-styles branch February 14, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie approved these changes

Assignees
No one assigned
Labels
✔️ compliance
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@obilodeau @ggrossetie