resolves #473 adds extra documentation on document structure and header #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
ggrossetie
reviewed
Jun 10, 2022
Co-authored-by: Guillaume Grossetie <ggrossetie@yuzutech.fr>
|
I've applied your suggestions. Please let me know if anything else requires editing. |
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
Mostly capitalisation channges. Co-authored-by: Guillaume Grossetie <ggrossetie@yuzutech.fr>
jhkuperus
commented
Jun 20, 2022
ggrossetie
reviewed
Jun 20, 2022
mojavelinux
reviewed
Jun 21, 2022
mojavelinux
reviewed
Jun 21, 2022
Co-authored-by: Guillaume Grossetie <ggrossetie@yuzutech.fr> Co-authored-by: Dan Allen <dan.j.allen@gmail.com>
ggrossetie
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
It's all good!
I will let @mojavelinux a chance to review one last time before merging 😉
mojavelinux
approved these changes
Jun 22, 2022
|
Thanks @jhkuperus for your contribution and @mojavelinux for your review 👍🏻 |
|
You're welcome and thanks for helping me help out the next person to get a smoother experience with this awesome tool :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the suggested extra notes and links. The sample-presentation now has an
IMPORTANTblock pointing out the need for proper document structure. It links to the page about the Title Slide. On the Title Slide page, I've added both a good and a bad example of a Document Header and a link to the AsciiDoc page on the Document Header.I couldn't find how to generate the site to test if my changes looked good. I installed antora, but I might have a newer version as it complains about incorrect configuration. If someone could tell me how to generate the site to verify if links work, I'll gladly do that before finalizing this PR.
I'm looking forward to your review.