Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement role attribute #43

Closed
cunka opened this issue Dec 25, 2022 · 1 comment
Closed

Implement role attribute #43

cunka opened this issue Dec 25, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@cunka
Copy link

cunka commented Dec 25, 2022

Would like to see asciidoctor-tabs have a full role attribute implemented and working.
This would keep it additionally consistent with the way other blocks works.

  • e.g. [tabs.chocolate]

https://docs.asciidoctor.org/asciidoc/latest/attributes/role/

Currently only the ID is working.

  • e.g. [tabs#redWine]

Currently, If we lazily put a "." proceeding the name, (example: [tabs.]) then the terminal will report an empty role.

The idea behind using the role feature on a block is the ability to use a CSS style on 1 or more tabset(s).
Some branding styling guidelines mandate the use of a class ahead of an ID, simply for streamlining into an existing website. Having the use of a role makes the implementation easier.

@mojavelinux
Copy link
Member

This seems like a reasonable request.

If we lazily put a "." proceeding the name, (example: [tabs.]) then the terminal will report an empty role.

That's normal behavior of Asciidoctor and is expected.

@mojavelinux mojavelinux added this to the v1.0.x milestone Jan 28, 2023
@mojavelinux mojavelinux added the enhancement New feature or request label Jan 28, 2023
@mojavelinux mojavelinux self-assigned this Jan 28, 2023
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants