Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic tab number should respect document order #61

Closed
mojavelinux opened this issue May 25, 2023 · 0 comments
Closed

Automatic tab number should respect document order #61

mojavelinux opened this issue May 25, 2023 · 0 comments
Assignees
Labels
bug Something isn't working v1.0.0-beta.5 v1.0.0
Milestone

Comments

@mojavelinux
Copy link
Member

When generating an ID for the tabs block (which also gets used to generate IDs for its child elements), the tab number used in the ID should follow the document order. Currently, if a tabs block is nested in another tab, the tab numbers become out of order. This happens since the children of a tabs block get parsed before the ID is generated for that tabs block. This can be corrected by reserving the tab number for the tabs block before parsing the children. In the event the extension does not return a tabs block, it must reset the tab number to the previous value (since it should not occupy a tab number).

@mojavelinux mojavelinux added the bug Something isn't working label May 25, 2023
@mojavelinux mojavelinux added this to the v1.0.x milestone May 25, 2023
@mojavelinux mojavelinux self-assigned this May 25, 2023
mojavelinux added a commit to mojavelinux/asciidoctor-tabs that referenced this issue May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0-beta.5 v1.0.0
Projects
None yet
Development

No branches or pull requests

1 participant