Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asciidoctor-kroki #301

Closed
cgoguyer opened this issue Apr 27, 2020 · 3 comments · Fixed by anb0s/asciidoctor-vscode#1 or #304
Closed

Update asciidoctor-kroki #301

cgoguyer opened this issue Apr 27, 2020 · 3 comments · Fixed by anb0s/asciidoctor-vscode#1 or #304

Comments

@cgoguyer
Copy link

Description

Some diagrams have been added in asciidoctor-kroki: packetdiag, rackdiag, vega, vegalite and wavedrom
So could you update dependencies to the latest release of asciidoctor-kroki => 0.8.2.

System Information

Currently asciidoctor-kroki 0.6.0 is implemented.

@danyill
Copy link
Contributor

danyill commented May 10, 2020

Thanks for this -- I'm quite keen on this myself. I've noticed a small issue with the kroki-fetch-diagram parameter and will try to get this integrated upstream but I don't think that's a reason not to integrate the latest version (but it will behave strangely if imagesoutdir, outdir, to_dir or base_dir are not set).

@anb0s
Copy link
Contributor

anb0s commented May 10, 2020

@danyill i've also faced issues with :kroki-fetch-diagram: true. I do not see the images in the configured imagedir folder like it's done by asciidoc-diagram. So the images are not shown then.

@danyill
Copy link
Contributor

danyill commented May 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants