Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The number of the chapter should be start from 0. #415

Closed
diguage opened this issue Jun 29, 2021 · 1 comment · Fixed by #418
Closed

The number of the chapter should be start from 0. #415

diguage opened this issue Jun 29, 2021 · 1 comment · Fixed by #418
Labels
🔗 dependencies Pull requests that update a dependency file 🙃 upstream
Milestone
2.8.10

Comments

@diguage
Copy link

diguage commented Jun 29, 2021

Description

I follow asciidoctor/asciidoctor#1434 (comment) to configure my document. But the start number of chapter is start from 1, not 0.

System Information

Version: 1.57.1
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:32.912Z (1 wk ago)
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 19.6.0

asciidoctor-vscode: v2.8.9

To Reproduce

Clone my repo, and open the assignment.adoc.

image

Use asciidoctor command to convert the document:

image

It's OK.

Screenshots & Files

https://github.com/huoqiangshou/fireworks/blob/master/assignment.adoc
@ggrossetie
Copy link
Member

I think we need to upgrade to Asciidoctor.js 2.2.4. This feature was inadvertently broke in Asciidoctor 2.0.13 core (Asciidoctor.js 2.2.3).

@ggrossetie ggrossetie added 🔗 dependencies Pull requests that update a dependency file 🙃 upstream labels Jul 2, 2021
@ggrossetie ggrossetie mentioned this issue Jul 2, 2021
Merged
ggrossetie added a commit that referenced this issue Jul 21, 2021
@ggrossetie
Upgrade to Asciidoctor.js 2.2.4 (#418)
32f05ef 
resolves #415
@danyill danyill added this to the 2.8.10 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔗 dependencies Pull requests that update a dependency file 🙃 upstream
Projects
None yet
Milestone
2.8.10
Development

Successfully merging a pull request may close this issue.

Upgrade to Asciidoctor.js 2.2.4 ggrossetie/asciidoctor-vscode
3 participants
@ggrossetie @danyill @diguage