Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce a code style (via a linter) to make the code consistent #446

Closed
ggrossetie opened this issue Sep 17, 2021 · 1 comment · Fixed by #448
Closed

Enforce a code style (via a linter) to make the code consistent #446

ggrossetie opened this issue Sep 17, 2021 · 1 comment · Fixed by #448
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Milestone
2.8.10

Comments

@ggrossetie
Copy link
Member

We could use ESLint with https://github.com/typescript-eslint/typescript-eslint or Standard I don't really mind but I think it's important to enforce a code style.
@ggrossetie ggrossetie added ✨ enhancement 💬 discussion Disccussion on new features, projects, etc... labels Sep 17, 2021
danyill added a commit to danyill/asciidoctor-vscode that referenced this issue Sep 17, 2021
@danyill
Enforce code style via linter (part of asciidoctor#446)
1c54549
@danyill danyill mentioned this issue Sep 17, 2021
Merged
@danyill
Copy link
Contributor

danyill commented Sep 17, 2021

I agree this is important. I've put a draft PR to look at this and discuss how we do it further.

ggrossetie added a commit that referenced this issue Sep 26, 2021
@danyill @ggrossetie
Enforce code style via linter (part of #446) (#448)
cd477c7 
* Add ESLint autofixed files
* Convert tabs to 2 spaces
* Solve the easy linting issues
* Add a few more, ignore linting on folders with 'test'
* Fix typos, more linter happiness, add rule to disallow semicolons
* Quote eslint properly, solve some more issues
* And some more linting goodness
* Update package-lock.json
* Some more linting happiness
* Replace Thenable by Promise
* Run CI on pull requests
* Fix null/undefined check conditions for PDF export

Co-authored-by: Guillaume Grossetie <ggrossetie@gmail.com>
@danyill danyill added this to the 2.8.10 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Projects
None yet
Milestone
2.8.10
Development

Successfully merging a pull request may close this issue.

Enforce code style via linter (part of #446) danyill/asciidoctor-vscode
2 participants
@ggrossetie @danyill