-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Asciidoctor VS code extension should not override the built-in HTML5 converter #478
Comments
Hi @Mogztter, when this extension will bump its used asciidoctor.js version to v2.2.6, the bug in my extension asciidoc slides should be fixed right? Or do i need this change here too? |
The bump should be enough but we should still do this change to avoid future issues. |
ggrossetie
added a commit
to ggrossetie/asciidoctor-vscode
that referenced
this issue
Feb 5, 2022
ggrossetie
added a commit
to ggrossetie/asciidoctor-vscode
that referenced
this issue
Feb 8, 2022
ggrossetie
added a commit
that referenced
this issue
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The Asciidoctor VS code extension should not override the built-in HTML5 converter because other converters might rely on it (namely https://github.com/flobilosaurus/vscode-asciidoc-slides)
To Reproduce
Steps to reproduce the issue:
Additional Context
Related issue: asciidoctor/asciidoctor.js#1475
We should not register our custom converter for
html5
but ratherwebview-html5
:asciidoctor-vscode/src/asciidocParser.ts
Line 12 in b7102ea
And then use the
backend
option to use our converter.The text was updated successfully, but these errors were encountered: