Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Asciidoctor VS code extension should not override the built-in HTML5 converter #478

Closed
ggrossetie opened this issue Dec 2, 2021 · 2 comments · Fixed by #513
Closed

Comments

@ggrossetie
Copy link
Member

Description

The Asciidoctor VS code extension should not override the built-in HTML5 converter because other converters might rely on it (namely https://github.com/flobilosaurus/vscode-asciidoc-slides)

To Reproduce

Steps to reproduce the issue:

  1. Install both the AsciiDoc and the AsciiDoc Slides extensions
  2. Try to show a slide preview

Additional Context

Related issue: asciidoctor/asciidoctor.js#1475

We should not register our custom converter for html5 but rather webview-html5:

processor.ConverterFactory.register(new AsciidoctorWebViewConverter(), ['html5'])

And then use the backend option to use our converter.

@flobilosaurus
Copy link

Hi @Mogztter, when this extension will bump its used asciidoctor.js version to v2.2.6, the bug in my extension asciidoc slides should be fixed right? Or do i need this change here too?

@ggrossetie
Copy link
Member Author

The bump should be enough but we should still do this change to avoid future issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants