Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable data-uri in the preview since it does not work #756

Closed
ggrossetie opened this issue Jul 16, 2023 · 0 comments · Fixed by #758
Closed

Disable data-uri in the preview since it does not work #756

ggrossetie opened this issue Jul 16, 2023 · 0 comments · Fixed by #758
Labels
🐞 bug

Comments

@ggrossetie
Copy link
Member

data-uri relies on the file system to embed all images in the document—​including admonition icons—​ into the document as data URIs.

If we want to support this feature in the preview we would need to implement it using VS code file system API: https://code.visualstudio.com/api/extension-guides/virtual-documents

In the meantime it seems better to forcibly disable it.
ggrossetie added a commit to ggrossetie/asciidoctor-vscode that referenced this issue Jul 16, 2023
@ggrossetie
resolves asciidoctor#756 disable data-uri
efde494
@ggrossetie ggrossetie mentioned this issue Jul 16, 2023
Merged
ggrossetie added a commit that referenced this issue Jul 16, 2023
@ggrossetie
resolves #756 disable data-uri (#758)
1ece505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #756 disable data-uri ggrossetie/asciidoctor-vscode
1 participant
@ggrossetie