Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #509 restructure code for testing #512

Merged
merged 1 commit into from
Feb 8, 2022
Merged

resolves #509 restructure code for testing #512

merged 1 commit into from
Feb 8, 2022

Conversation

ggrossetie
Copy link
Member

What I did

  • Fix Cannot read property 'startsWith' of undefined #509
  • Simplify condition from if (!(pdfUri === null || pdfUri === undefined)) to if (pdfUri)
  • Use isAttribute to check if showTitlePage is defined
  • Extract code into a function for testing: _generateCoverHtmlContent
  • Use try/catch around await instead of using then and catch

resolves #509

@ggrossetie ggrossetie merged commit 0f99b97 into asciidoctor:master Feb 8, 2022
@ggrossetie ggrossetie deleted the issue-509-export-pdf branch February 8, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyill danyill Awaiting requested review from danyill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'startsWith' of undefined
1 participant
@ggrossetie