Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce bundle size #517

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Reduce bundle size #517

merged 1 commit into from
Feb 8, 2022

Conversation

ggrossetie
Copy link
Member

What I Did

  • Move @types/vscode to devDependencies
  • Move eslint-config-standard to devDependencies
  • Move vscode-test to devDependencies
  • Replace moment() by built-in Date. Moment is 289.7kB minified: https://bundlephobia.com/package/moment@2.29.1

@ggrossetie
Copy link
Member Author

Bundle size goes from 2.8mb to 2.6mb (when applied to #506)

@ggrossetie ggrossetie merged commit 6f8b579 into asciidoctor:master Feb 8, 2022
@ggrossetie ggrossetie deleted the bundle-size branch February 8, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ggrossetie