Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html2pdf #528

Merged
Merged

Conversation

gurbindersingh
Copy link
Contributor

Changes:

  • Fix if-statement
  • Fix type of footerCenter
  • Reformat method signature (line exceeded 160 characters)

Resolves #526

Changes:
- Fix if-statement
- Fix type of footerCenter
- Reformat method signature (line exceeded 160 characters)

Resolves asciidoctor#526
@ggrossetie
Copy link
Member

It looks good to me, thanks @gurbindersingh for this first contribution 🎉

@ggrossetie ggrossetie merged commit 5988e54 into asciidoctor:master Mar 1, 2022
@gurbindersingh gurbindersingh deleted the issue-526-fix-html2pdf branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer in PDF only says "undefined"
2 participants