Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #527 activate completion when : is at the start of the line #529

Merged

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Mar 1, 2022

What I did

Extract all built-in attribute snippets in order to create a completion provider

autocompletion-doc-attribute

As you can see, built-in document attribute suggestions only show when : is typed at the beginning of the line.

Improve the AttributeReferenceProvider to add leading { or trailing } if missing

autocompletion-attribute-ref

resolves #527

@ggrossetie ggrossetie force-pushed the issue-527-attribute-completion branch from 79c6ec0 to 44ccbeb Compare March 1, 2022 19:46
@ggrossetie ggrossetie requested a review from danyill March 1, 2022 22:00
@ggrossetie ggrossetie merged commit aee2f61 into asciidoctor:master Mar 2, 2022
@ggrossetie ggrossetie deleted the issue-527-attribute-completion branch March 2, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't easily type a colon at the end of a line
1 participant