resolves #320 set CSS variables for font size, font family and line height

[ggrossetie]

Use --asciidoc-font-family, --asciidoc-font-size and --asciidoc-line-height variables.

Fix #320
Fix #365

[danyill]

I will take a look this weekend :-)

[danyill]

Thank you for the opportunity to review this.

I have made a few comments but I don't think having full control over line height is worth much effort as a feature and making this comprehensive could be some work...

I think we should remove the duplicate line-height definition but anything else I'm not sure about.

[ggrossetie]

I think we should remove the duplicate line-height definition but anything else I'm not sure about.

I removed the duplicate line-height and I'm now using calc to compute the value relative to var(--asciidoc-line-height, 1.6).
For instance, line-height: 1; is equivalent to line-height: calc(var(--asciidoc-line-height, 1.6) * 0.625); when --asciidoc-line-height is 1.6.

In my opinion, it gives a decent result.

[danyill]

I can't get a preview at all at present with either the default or the editor stylesheet. Some of it is due to incorrect line-height definitions but there is something else which I am struggling to find. I'll look for a little bit more (I don't have good tools or approach for this and my 👀 fail me).

[danyill]

In my opinion, it gives a decent result.

Very nice. I like the use of calc.

Although I can't find it, somehow both CSS files are invalid and on my machine I can't receive a preview. We must have somehow slightly different environments that this is working for you or I am missing a commit (?).

I don't get any useful debug information on this error in the extension host logs or the webview developer tools console.

I see:

Error loading webview: Error: Could not register service workers: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..
onDidChangeNotification @ workbench.desktop.main.js:787

I think this means there is a CSS definition problem somewhere as nothing else has changed but I can't find it and neither can the linter or https://jigsaw.w3.org/css-validator/validator

[ggrossetie]

Although I can't find it, somehow both CSS files are invalid and on my machine I can't receive a preview. We must have somehow slightly different environments that this is working for you or I am missing a commit (?).

line-height was missing on a few places in asciidoctor-default.css but asciidoctor-editor.css was fine and now both are working on my end.

I don't get any useful debug information on this error in the extension host logs or the webview developer tools console.
I think this means there is a CSS definition problem somewhere as nothing else has changed but I can't find it and neither can the linter or jigsaw.w3.org/css-validator/validator

Not sure... for reference, I'm testing using the test-workspace/full.adoc file.

[danyill]

Not sure... for reference, I'm testing using the test-workspace/full.adoc file.

Somehow my node_modules were polluted and a refresh fixed it.

I have tested and I think that's a great implementation 👍