New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #497 introduce a load function #541

Merged

ggrossetie merged 1 commit into asciidoctor:master from ggrossetie:load-function

Mar 6, 2022

Member

ggrossetie commented Mar 6, 2022 •

edited

What I Did

Extract SkinnyTextDocument into util/document.ts
Introduce a load function in AsciidocParser that returns the Asciidoctor.Document and a list of IncludeEntry
Remove getMediaDir from AsciidocParser (was unused)
Remove baseDocumentIncludeItems instance variable on AsciidocParser (since the load function now returns this information)
Remove getDocumentInformation from the convertUsingJavascript

resolves #497

ggrossetie requested a review from danyill

March 6, 2022 11:41


          resolves asciidoctor#497 introduce a load function

9ae1aaf

ggrossetie force-pushed the load-function branch from f13e9df to 9ae1aaf Compare

March 6, 2022 12:58

ggrossetie merged commit e96ac0b into asciidoctor:master

ggrossetie deleted the load-function branch

March 6, 2022 13:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment