Add code folding on single line comment #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Apr 10, 2022
ggrossetie
reviewed
Apr 10, 2022
src/features/foldingProvider.ts
Outdated
| const startIndex = singleLineCommentStartIndexes.pop() | ||
| const endIndex = lineIndex - 1 | ||
| if (endIndex - startIndex > 0) { | ||
| foldingRanges.push(new vscode.FoldingRange( |
There was a problem hiding this comment.
We should also create a folding range when singleLineCommentStartIndexes is not empty and we are on the last line. For instance:
This is a paragraph.
// This is a comment.
// The last line of the document is also a comment!
marieflorescontact
force-pushed
the
Add-code-folding-on-single-line-comment-block
branch
from
31f94b0
to
226e5f4
Compare
ggrossetie
reviewed
Apr 11, 2022
marieflorescontact
force-pushed
the
Add-code-folding-on-single-line-comment-block
branch
from
61d7554
to
6dc1e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd step of #560 issue: code folding on single line comment.