Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed for localization issue #594

Merged

Conversation

YoshihideShirai
Copy link
Contributor

@YoshihideShirai YoshihideShirai commented Jul 5, 2022

Hi, @Mogztter .

I found a issue that relate a localization .
Localizations didn't work except config's titles or descriptions.

vscode-nls-dev has procedure which is following...

  1. Search nls.loadMessageBundle() from js files
  2. Create xxx.nls.json by js file name which is found in "1.".
  3. Create *.nls.[jp/fr].json from a i18n directory and "2.".

In current master branch, only i18n.ts has nls.loadMessageBundle().
I think that it is a bad implementation.

Can you check it?
And, please translate English message in i18n/fra/src/security.i18n.json.

@ggrossetie
Copy link
Member

I think you are right, my goal was to load and configure nls.config({ messageFormat: nls.MessageFormat.file })() only once but indeed nls.rewriteLocalizeCalls rewrites calls per JavaScript file.

I wonder how it's gonna work if we produce a single JavaScript file: #506.

Anyway, I will fetch your branch locally and update the French/English localization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants