Windows support for Electron #189
Conversation
Indeed this is not a simple task and we will just test our implementation anyway 😐 |
| @@ -1,5 +1,6 @@ | |||
| %x( | |||
| var isNode = typeof module !== 'undefined' && module.exports, | |||
| isElectron = process.versions !== undefined && process.versions.electron !== undefined, | |||
There was a problem hiding this comment.
maybe we should check that process is defined ?
There was a problem hiding this comment.
process is always defined with Node
There was a problem hiding this comment.
oops isXX are not functions, I must test if process is defined.
|
@mojavelinux I don't remember if we agreed on a naming to define the runtime environment ? Electron should be: JAVASCRIPT_ENGINE=electron
JAVASCRIPT_PLATFORM=node // or maybe nodejs ? |
|
|
Yes you are right, that was part of the discussion but I think we "formalize" something (the problem is that I can't remember where) |
|
I think we can track this improvement in another issue |
|
👍 Thanks @ldez |
Related to electron/electron#2033
Fix asciidoctor/atom-asciidoc-preview#159
I don't know how to write specs for this case.