Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toc should not be automatically added to AsciiDoc table cell #1582

Closed
mojavelinux opened this issue Nov 21, 2015 · 1 comment
Closed

toc should not be automatically added to AsciiDoc table cell #1582

mojavelinux opened this issue Nov 21, 2015 · 1 comment
Assignees
@mojavelinux
Labels
bug
Milestone
v1.5.4

Comments

@mojavelinux
Copy link
Member

When the toc was added for embedded documents, it started to appear inside AsciiDoc table cells. If the toc is enabled on a document, it should not appear automatically in an AsciiDoc table cell.
@mojavelinux mojavelinux self-assigned this Nov 21, 2015
@mojavelinux mojavelinux added this to the v1.5.4 milestone Nov 21, 2015
@mojavelinux mojavelinux mentioned this issue Nov 21, 2015
Closed
@mojavelinux
Copy link
Member Author

To workaround the issue, it's necessary to unset the toc attribute below the document header.

= Document Title
Author Name
:toc: right

:toc!:

content

The placement of the blank line above the :toc!: line is significant.

@mojavelinux mojavelinux mentioned this issue Nov 21, 2015
Closed
This was referenced Dec 4, 2015
Closed
Closed
@mojavelinux mojavelinux mentioned this issue Dec 17, 2015
Closed
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Dec 21, 2015
@mojavelinux
resolves asciidoctor#1582 don't include default toc in nested document
4968efc 
- prevent default toc from being inserted into AsciiDoc table cell
@mojavelinux mojavelinux added wip and removed next labels Dec 21, 2015
mojavelinux added a commit that referenced this issue Dec 22, 2015
@mojavelinux
Merge pull request #1624 from mojavelinux/issue-1582
d46abe7 
resolves #1582 don't include default toc in nested document
@mojavelinux mojavelinux removed the wip label Dec 22, 2015
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Dec 23, 2015
@mojavelinux
reresolves asciidoctor#1582 don't pass toc location attributes to sub…
0ccddb8 
…document

- don't pass toc location attributes (toc, toc-placement, toc-position) to subdocument
- allow toc to be enabled in AsciiDoc table cell
- add tests for more toc scenarios in AsciiDoc table cell
mojavelinux added a commit that referenced this issue Dec 26, 2015
@mojavelinux
Merge pull request #1628 from mojavelinux/issue-1582
b4d70d7 
reresolves #1582 don't pass toc location attributes to subdocument
This was referenced Dec 28, 2015
Closed
Closed
ggrossetie pushed a commit to ggrossetie/asciidoctor that referenced this issue Jun 23, 2016
@mojavelinux @ggrossetie
resolves asciidoctor#1582 don't include default toc in nested document
5803063 
- prevent default toc from being inserted into AsciiDoc table cell
- add test to cover scenario
ggrossetie pushed a commit to ggrossetie/asciidoctor that referenced this issue Jun 23, 2016
@mojavelinux @ggrossetie
reresolves asciidoctor#1582 don't pass toc location attributes to sub…
8eef0d9 
…document

- don't pass toc location attributes (toc, toc-placement, toc-position) to subdocument
- allow toc to be enabled in AsciiDoc table cell
- add tests for more toc scenarios in AsciiDoc table cell
@ricklarsen ricklarsen mentioned this issue Aug 25, 2016
Merged
3 tasks
@leif81 leif81 mentioned this issue Sep 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug
Projects
None yet
Milestone
v1.5.4
Development

No branches or pull requests
1 participant
@mojavelinux