Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset attributes don't inherit to AsciiDoc table cell #2586

Closed
mojavelinux opened this issue Mar 2, 2018 · 1 comment · Fixed by #3584
Closed

Unset attributes don't inherit to AsciiDoc table cell #2586

mojavelinux opened this issue Mar 2, 2018 · 1 comment · Fixed by #3584
Assignees
Labels
bug v2.0.14 Issues resolved in the 2.0.14 release
Milestone

Comments

@mojavelinux
Copy link
Member

Attributes which are unset in the main document do not remain unset inside an AsciiDoc table cell.

Example:

:example-caption!:

|===
a|
.Title
====
example in table
====
|===

The caption on the example should not include the label and number (e.g., Example 1), but it does.

@mojavelinux mojavelinux added the bug label Mar 2, 2018
@mojavelinux mojavelinux self-assigned this Mar 2, 2018
@mojavelinux mojavelinux added this to the v1.6.0 milestone Mar 2, 2018
@mojavelinux mojavelinux modified the milestones: v1.6.0, M2 Jan 9, 2019
@mojavelinux mojavelinux modified the milestones: M2, v2.0.x Feb 24, 2020
@mojavelinux
Copy link
Member Author

The relationship between the main document and the AsciiDoc table cell is no well defined. But I think it's reasonable to assume that default attributes that have been unset in the main document remain unset in the AsciiDoc table cell document.

We'll need to have a separate, larger conversation about what the inheritance and override rules really should be.

mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 24, 2020
…in document should remain unset in the AsciiDoc table cell document
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Feb 24, 2020
…ain document should remain unset in the AsciiDoc table cell document
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 16, 2021
…document remain unset in AsciiDoc table cell (nested) document
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 18, 2021
…document remain unset in AsciiDoc table cell (nested) document
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 18, 2021
…document remain unset in AsciiDoc table cell (nested) document
mojavelinux added a commit that referenced this issue Apr 18, 2021
…main unset in AsciiDoc table cell (nested) document (PR #3584)
@mojavelinux mojavelinux added the v2.0.14 Issues resolved in the 2.0.14 release label Apr 18, 2021
ggrossetie pushed a commit to ggrossetie/asciidoctor that referenced this issue Jun 12, 2021
…document remain unset in AsciiDoc table cell (nested) document (PR asciidoctor#3584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v2.0.14 Issues resolved in the 2.0.14 release
Projects
None yet
1 participant