Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map location of table cell when sourcemap option is enabled #2705

Closed
3 tasks done
mojavelinux opened this issue Apr 23, 2018 · 0 comments
Closed
3 tasks done

Map location of table cell when sourcemap option is enabled #2705

mojavelinux opened this issue Apr 23, 2018 · 0 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.7

Comments

@mojavelinux
Copy link
Member

mojavelinux commented Apr 23, 2018 •
edited

When the sourcemap option is enabled via the API, map the location of each table cell by assigning the cursor to the source_location property.

Done criteria:

  • Add source_location property to Asciidoctor::Table::Cell
  • When the :sourcemap option is enabled on the document, assign the value of the table reader's cursor property to the source_location property on the Cell
  • Add tests to verify the source_location property contains the correct information
@mojavelinux mojavelinux added this to the v1.5.7 milestone Apr 23, 2018
@mojavelinux mojavelinux self-assigned this Apr 23, 2018
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 24, 2018
@mojavelinux
resolves asciidoctor#2705 populate source_location property on cell w…
16d3834 
…hen sourcemap option is enabled

- add source_location property to Table::Cell
- add file and lineno methods to Table::Cell
- when sourcemap option is enabled, set source_location property on cell
- mark first line of table so line number for first cell is correct
- add test to verify source_location information on table cell is correct
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 25, 2018
@mojavelinux
resolves asciidoctor#2705 populate source_location property on cell w…
d4b100e 
…hen sourcemap option is enabled

- add source_location property to Table::Cell
- add file and lineno methods to Table::Cell
- when sourcemap option is enabled, set source_location property on cell
- mark first line of table so line number for first cell is correct
- add tests to verify source_location information on table cell is correct
@mojavelinux mojavelinux removed the wip label Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.7
Development

No branches or pull requests
1 participant
@mojavelinux