Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slim::Engine emits warning about invalid option when using custom slim templates #2928

Closed
mojavelinux opened this issue Oct 21, 2018 · 2 comments
Closed

Slim::Engine emits warning about invalid option when using custom slim templates #2928

mojavelinux opened this issue Oct 21, 2018 · 2 comments
Assignees
@mojavelinux
Labels
compliance
Milestone
v1.5.8

Comments

@mojavelinux
Copy link
Member

Since Slim 4, Slim now validates the names of all options passed to the template. Slim issues a warning for any option that isn't registered with Slim::Engine. Since the :asciidoc option is not registered, Slim::Engine emits a warning when using custom slim templates with Asciidoctor.

The fix is to register the :asciidoc option so Slim knows to expect it.
@mojavelinux mojavelinux added this to the v1.5.8 milestone Oct 21, 2018
@mojavelinux mojavelinux self-assigned this Oct 21, 2018
@mojavelinux
Copy link
Member Author

cc: @ctargett

mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Oct 21, 2018
@mojavelinux
resolves asciidoctor#2928 prevent warning about invalid :asciidoc o…
9fd9f66 
…ption when using custom templates with Slim 4
@ctargett
Copy link

Thanks @mojavelinux!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
compliance
Projects
None yet
Milestone
v1.5.8
Development

No branches or pull requests
2 participants
@mojavelinux @ctargett