Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log messages should not refer to preprocessor directives as macros #3165

Closed
mojavelinux opened this issue Mar 19, 2019 · 0 comments
Closed

Log messages should not refer to preprocessor directives as macros #3165

mojavelinux opened this issue Mar 19, 2019 · 0 comments
Assignees
@mojavelinux
Labels
compliance
Milestone
v2.0.0

Comments

@mojavelinux
Copy link
Member

The log messages for an mismatched or malformed preprocessor directives still refer to them as macros. This is outdated terminology. Update the messages to use the correct terminology.
@mojavelinux mojavelinux added this to the v2.0.0 milestone Mar 19, 2019
@mojavelinux mojavelinux self-assigned this Mar 19, 2019
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Mar 19, 2019
@mojavelinux
resolves asciidoctor#3165 use proper terminology in warning message a…
8f6a008 
…bout mismatched preprocessor directive

- use proper terminology in warning message for preprocessor directive
- add tests for unmatched and mismatched preprocessor directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
compliance
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@mojavelinux