New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double quotes around URL macro prevent it from being converted #3376
Comments
As in, we should allow double quotes around a URL or URL macro? |
Yes. |
What is the exhaustive list of allowed enclosing characters?
When we detect a valid prefix (i.e.
Not sure about the second, maybe we should consider that this is not a valid link since the suffix is not in compliance with the prefix? It's more strict but might avoid some confusions. Implementation wise, I think it might the right time to fix the following "FIXME", otherwise, the regular expression and the associated code will be hard to grasp. # FIXME revisit! the main issue is we need different rules for implicit vs explicit |
I'm not interested right now in considering all permutations. I want to stay focused on the inconsistency at hand. |
What it probably should be is that the URL protocol as macro name should be treated the same way as the link macro. But there are various reasons why that is not easily supported as the code currently stands. So it may be something we look at in the spec. Until then, just allows the URL protocol to be prefixed with a quote goes a long way. |
…e or double quote
That needs to wait until at least a minor release (and maybe even a major one). |
…e or double quote
The reason this one is not supported is because of the way substitutions are currently done in AsciiDoc. This would end up catching href attributes returned by partially converted text and would wreck havoc on the result. |
Enclosing a URL or URL macro in double quotes prevents it from being recognized and converted. For example:
However, it's acceptable to put double quotes around an explicit link macro or xref macro.
The behavior should be consistent.
The text was updated successfully, but these errors were encountered: