Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override the built-in "user-home" attribute #3732

Closed
ggrossetie opened this issue Aug 12, 2020 · 0 comments
Closed

Allow to override the built-in "user-home" attribute #3732

ggrossetie opened this issue Aug 12, 2020 · 0 comments
Assignees
@mojavelinux
Labels
improvement v2.0.14 Issues resolved in the 2.0.14 release
Milestone
v2.0.x

Comments

@ggrossetie
Copy link
Member

Currently, the value of user-home is inferred using Ruby ::Dir.home method (if this method fails, Asciidoctor will use ENV['HOME'] or Dir.pwd):

asciidoctor/lib/asciidoctor.rb

Line 189 in 88bc891

USER_HOME = ::Dir.home rescue (::ENV['HOME'] || ::Dir.pwd)

Moreover, in some environments (for instance, in the browser) the value cannot be inferred.
Since the value can potentially be incorrect (or cannot be inferred) it should be possible to define/override the inherent value.
@ggrossetie ggrossetie mentioned this issue Aug 12, 2020
Closed
@mojavelinux mojavelinux self-assigned this Apr 19, 2021
@mojavelinux mojavelinux added this to the v2.0.x milestone Apr 19, 2021
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 19, 2021
@mojavelinux
resolves asciidoctor#3732 allow value of user-home attribute to be …
dc9a5c9 
…overridden by API or CLI
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 19, 2021
@mojavelinux
resolves asciidoctor#3732 allow value of user-home attribute to be ov…
44181bf 
…erridden by API or CLI
@mojavelinux mojavelinux added the v2.0.14 Issues resolved in the 2.0.14 release label Apr 19, 2021
ggrossetie pushed a commit to ggrossetie/asciidoctor that referenced this issue Jun 12, 2021
@mojavelinux @ggrossetie
resolves asciidoctor#3732 allow value of user-home attribute to be ov…
739fd44 
…erridden by API or CLI (PR asciidoctor#4030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement v2.0.14 Issues resolved in the 2.0.14 release
Projects
None yet
Milestone
v2.0.x
Development

No branches or pull requests
2 participants
@mojavelinux @ggrossetie