Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow footnotes in footnotes #3893

Open
hedrok opened this issue Dec 28, 2020 · 0 comments
Open

Allow footnotes in footnotes #3893

hedrok opened this issue Dec 28, 2020 · 0 comments

Comments

@hedrok
Copy link
Contributor

hedrok commented Dec 28, 2020

Thanks for all your work on asciidoctor!

I can't find a way to make footnote to footnote work, e. g.:

Textfootnote:[Footnote to textfootnote:[Footnote to footnote.]. Rest of footnote].

Generates one footnote before first ], the rest is in text.

(In Ukrainian translation of Terry Pratchett's Discworld there are a lot of author's footnotes, including footnotes to footnotes.)

I've prepared PR that fixes this problem.
hedrok added a commit to hedrok/asciidoctor that referenced this issue Dec 28, 2020
@hedrok
resolves asciidoctor#3893 allow footnotes in footnotes
2c02055 
* Add 2 tests: basic support of footnotes in footnotes
  and support for escaped ]
* Change InlineFootnoteMacroRx so that it allows recursive footnotes
* Move footnote processing code from sub_macros to separate function
  sub_footnote, call it recursively on matches. It is important not
  to call sub_macros recursively as this results to multiple expansion
  of some macros (e.g. URL)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hedrok and others