New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should handle classloader URI as an absolute path when running on JRuby #3929
Comments
ex. uri:classloader:/path/to/image Note that ::File.absolute_path? (as well as Pathname#absolute?) recognizes this as an absolute path. |
There are several cases to consider here, not all of which go through normalize_system_path
|
This one is tougher. The reason is, the dest will end up being the src, and thus the stylesheet won't be copied. Dedicated logic will be required. |
…fix when running on JRuby
Actually, it's no problem after all. If |
The one outstanding restriction is that if the safe mode is safe or greater, the resources will only be read if the base/jail is a parent classloader URI. We can revisit this restriction in a separate issue. The simplest workaround when mixing local paths and classloader URIs is to set the safe mode to unsafe. |
…fix when running on JRuby
…fix when running on JRuby
This fix will also prevent the following warning when including a file from the classloader:
|
…fix when running on JRuby
…fix when running on JRuby
The virtual path represented by a classloader URI should be respected when running on JRuby. This means normalize_system_path should pass it through and is_uri? should return false.
The text was updated successfully, but these errors were encountered: