You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the attrlist parser was updated to account for empty positional attributes to solve #3813, it resulted in an attribute mapped to that position being assigned a nil value. This presents a challenge for converters, which often assume that if an attribute is set, the value is non-nil.
The affect of this can be seen in the handling of the block image macro. If the positional attribute for width is empty, like in this example:
image::tux.png[Tux,]
It results in an empty width attribute in the HTML output:
<img src="tux.png" width="">
This output differs from earlier version of Asciidoctor.
The mapped attribute should only be assigned if the value is non-nil.
The text was updated successfully, but these errors were encountered:
It's interesting to note that the AttributeList.rekey method already works this way. It's the logic integrated with the attrlist parsing that's behaving incorrectly.
mojavelinux
added a commit
to mojavelinux/asciidoctor
that referenced
this issue
Apr 22, 2021
When the attrlist parser was updated to account for empty positional attributes to solve #3813, it resulted in an attribute mapped to that position being assigned a nil value. This presents a challenge for converters, which often assume that if an attribute is set, the value is non-nil.
The affect of this can be seen in the handling of the block image macro. If the positional attribute for width is empty, like in this example:
It results in an empty width attribute in the HTML output:
This output differs from earlier version of Asciidoctor.
The mapped attribute should only be assigned if the value is non-nil.
The text was updated successfully, but these errors were encountered: