Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description list next item mistakenly a child after nesting #4268

Closed
jaskij opened this issue Mar 16, 2022 · 2 comments
Closed

Description list next item mistakenly a child after nesting #4268

jaskij opened this issue Mar 16, 2022 · 2 comments
Assignees
Labels
bug compliance v2.0.19 Issues resolved in the 2.0.19 release
Milestone

Comments

@jaskij
Copy link

jaskij commented Mar 16, 2022

Below is description adapted from #1872 (comment), originally by @mojavelinux.

Operating Systems::
[horizontal]
  Linux::: Linux
  BSD::: BSD

Cloud Providers::
  PaaS::: PaaS
  IaaS::: IaaS

The second label is getting caught up as a child of the nested list. To workaround this problem, you can attach the nested list using a list continuation.

Operating Systems::
+
[horizontal]
  Linux::: Linux
  BSD::: BSD

Cloud Providers::
  PaaS::: PaaS
  IaaS::: IaaS

I'm experiencing this on Arch Linux, Asciidoctor and Ruby version below.

$ asciidoctor --version
Asciidoctor 2.0.17 [https://asciidoctor.org]
Runtime Environment (ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]) (lc:UTF-8 fs:UTF-8 in:UTF-8 ex:UTF-8)
$ ruby --version
ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]
@mojavelinux
Copy link
Member

Thanks for reminding me of this parsing issue. This is a good test case. I'll schedule it for the 2.1.0 release and backport it to 2.0.x if possible.

@mojavelinux mojavelinux self-assigned this Mar 16, 2022
@mojavelinux mojavelinux added this to the v2.1.x milestone Mar 16, 2022
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 21, 2023
…ith block attribute lines to dlist entry
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 21, 2023
…ith block attribute lines to dlist entry
@mojavelinux
Copy link
Member

The contract in AsciiDoc is that list items can be nested without a list continuation. If the nested list has a block attribute line above it, that should still be permitted. That's what's not being allowed but should be.

One restriction is that the block attribute line must be directly adjacent to the term or wrapped principal text (no empty line above it). However, if an adjacent block attribute line is found, then there can be empty lines between subsequent block attribute lines (they are tolerated).

The second label is getting caught up as a child of the nested list.

That's not actually what's happening. Instead, there are two top-level lists. If you write it that way explicitly, you would observe the same behavior.

mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 21, 2023
…ith block attribute lines to dlist entry
mojavelinux added a commit that referenced this issue Apr 23, 2023
@mojavelinux mojavelinux added the v2.0.19 Issues resolved in the 2.0.19 release label Apr 26, 2023
@mojavelinux mojavelinux modified the milestones: v2.1.x, v2.0.x Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug compliance v2.0.19 Issues resolved in the 2.0.19 release
Projects
None yet
Development

No branches or pull requests

2 participants