Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First call to Asciidoctor::Extensions.unregister should not fail if extensions aren't initialized #4270

Closed
mojavelinux opened this issue Mar 19, 2022 · 2 comments
Closed

First call to Asciidoctor::Extensions.unregister should not fail if extensions aren't initialized #4270

mojavelinux opened this issue Mar 19, 2022 · 2 comments
Assignees
@mojavelinux
Labels
bug v2.0.18 Issues resolved in the 2.0.18 release
Milestone
v2.0.x

Comments

@mojavelinux
Copy link
Member

If Asciidoctor::Extensions.unregister is called before any extensions are registered, the method raises a NilClass error. This happens because the groups instance variable has not yet been instantiated. The method should guard against this scenario.
@mojavelinux mojavelinux self-assigned this Mar 19, 2022
@mojavelinux mojavelinux added this to the v2.1.x milestone Mar 19, 2022
@mojavelinux
Copy link
Member Author

Backport the fix to v2.0.x.

@mojavelinux mojavelinux added v2.1.0 Issues resolved in the 2.1.0 release. v2.0.18 Issues resolved in the 2.0.18 release labels Apr 4, 2022
mojavelinux added a commit that referenced this issue Apr 4, 2022
@mojavelinux
resolves #4270 don't raise error if Asciidoctor::Extensions.unregiste…
0ba8980 
…r is called before groups are initialized
mojavelinux added a commit that referenced this issue Apr 4, 2022
@mojavelinux
fix issue reference for #4270 [skip ci]
5d04cad
@mojavelinux
Copy link
Member Author

resolved by 0aad745

@mojavelinux mojavelinux removed the v2.1.0 Issues resolved in the 2.1.0 release. label Oct 16, 2022
@mojavelinux mojavelinux modified the milestones: v2.1.x, v2.0.x Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug v2.0.18 Issues resolved in the 2.0.18 release
Projects
None yet
Milestone
v2.0.x
Development

No branches or pull requests
1 participant
@mojavelinux