Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't split value of -r CLI option on comma #4425

Closed
mojavelinux opened this issue Apr 2, 2023 · 0 comments
Closed

Don't split value of -r CLI option on comma #4425

mojavelinux opened this issue Apr 2, 2023 · 0 comments
Assignees
Labels
area/cli Issues related to the CLI improvement v2.1.0 Issues resolved in the 2.1.0 release.
Milestone

Comments

@mojavelinux
Copy link
Member

Currently, if the value of the -r CLI option contains a comma, the CLI will split the value on the comma and treat it as two separate paths.

There's really no need for this magic since the -r option may be specified multiple times. It can introduce problems if the filename contains a comma, which is a valid filename character. And there's no way to escape it. Therefore, the value of this option should be accepted as is rather than being interpreted. It's not a documented behavior anyway.

@mojavelinux mojavelinux self-assigned this Apr 2, 2023
@mojavelinux mojavelinux added this to the v2.1.x milestone Apr 2, 2023
@mojavelinux mojavelinux added the area/cli Issues related to the CLI label Apr 2, 2023
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 9, 2023
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Apr 15, 2023
@mojavelinux mojavelinux added the v2.1.0 Issues resolved in the 2.1.0 release. label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Issues related to the CLI improvement v2.1.0 Issues resolved in the 2.1.0 release.
Projects
None yet
Development

No branches or pull requests

1 participant