Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only drop current row when cell colspan overruns specified number of columns #4587

Closed
mojavelinux opened this issue May 15, 2024 · 0 comments
Closed

Only drop current row when cell colspan overruns specified number of columns #4587

mojavelinux opened this issue May 15, 2024 · 0 comments
Assignees
@mojavelinux
Labels
bug compliance v2.0.23 Issues resolved in the 2.0.23 release
Milestone
v2.0.x

Comments

@mojavelinux
Copy link
Member

The way table parsing is done, it ends up dropping subsequent rows when a cell colspan overruns the specified number of columns. It also misses certain cases of when the cell colspan overruns the specified number of columns. The parsing logic should be updated to stop processing the current row when the number of specified columns is exceeded and reset the context before parsing the next row.
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue May 15, 2024
@mojavelinux
resolves asciidoctor#4587 only drop current row if colspan of last ce…
a05bc28 
…ll exceeds specified number of columns
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue May 15, 2024
@mojavelinux
resolves asciidoctor#4587 only drop current row if colspan of last ce…
7a017af 
…ll exceeds specified number of columns
@mojavelinux mojavelinux self-assigned this May 15, 2024
@mojavelinux mojavelinux added this to the v2.0.x milestone May 15, 2024
@mojavelinux mojavelinux added v2.0.23 Issues resolved in the 2.0.23 release bug compliance labels May 15, 2024
mojavelinux added a commit that referenced this issue May 15, 2024
@mojavelinux
backport fix for #4587 only drop current row if colspan of last cell …
9c21d85 
…exceeds specified number of columns
@mojavelinux mojavelinux mentioned this issue May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug compliance v2.0.23 Issues resolved in the 2.0.23 release
Projects
None yet
Milestone
v2.0.x
Development

No branches or pull requests
2 participants
@mojavelinux and others