Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't match fenced code block that has four backticks #611

Closed
mojavelinux opened this issue Aug 30, 2013 · 1 comment
Closed

Don't match fenced code block that has four backticks #611

mojavelinux opened this issue Aug 30, 2013 · 1 comment
Assignees
Labels
Milestone

Comments

@mojavelinux
Copy link
Member

Do to a logic error in the parsing code, 4 backticks are being recognized as the start of a fenced code block, but only 3 are searched for the trailing delimiter. This causes the remainder of the document to break.

Create a negative test case for the following snippet.

````ruby
puts "Hi"
````

Make sure that doesn't match, or break the document.

@ghost ghost assigned mojavelinux Aug 30, 2013
@mojavelinux
Copy link
Member Author

While we're at it, honor the the line number setting after the first fence:

```xml,numbered
<root/>
````

Any value in the second position after the comma should be interpreted as enabling line numbers. This covers all three positional attributes for the source block (the first, the block style source, being implied).

mojavelinux added a commit that referenced this issue Aug 31, 2013
resolves #611 don't match fenced code block w/ 4 ticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant