Port tests to haml 6

[terceiro]

Fixes: #4382

[mojavelinux]

Thanks for taking this on!

We will still need to test again Haml 5 for compatibility reasons. Would you be able to add conditionals in such a way that the tests work with either version? I'll then make sure the CI matrix is set up to run on both major versions.

[terceiro]

Thanks for taking this on!

We will still need to test again Haml 5 for compatibility reasons. Would you be able to add conditionals in such a way that the tests work with either version? I'll then make sure the CI matrix is set up to run on both major versions.

There.

[mojavelinux]

Thanks! I'll review as soon as you think it's ready to go. Just give me the signal.

[terceiro]

this should be ready. I tested against haml 5 and 6 by hacking the Gemfile, and it works

[thesamesam]

Thanks for this, I was just trying to figure out why the tests were failing for us :)

@mojavelinux any chance you're able to review?

[mojavelinux]

Superseded by #4431.

I don't want to introduce an intermediary class to add support for Haml 6, and I don't think it's necessary. Instead, I want to use the existing infrastructure in the template converter to deal with option variance. However, this PR did point me to what needed to be changed, so I very much appreciate the contribution.

I tested against haml 5 and 6 by hacking the Gemfile, and it works

We can't just rely on local testing. I added a profile to the CI workflow to run the test suite using Haml 5 in additional to Haml 6.