CLI should set :mkdirs option by default (#1241) (#1244)

* CLI should set :mkdirs option by default (#1241) * Simplify test by avoiding use of wildcards
asciidoctor · Nov 23, 2023 · c7aba4f · c7aba4f
1 parent 616e74a
commit c7aba4f
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 0 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -17,6 +17,10 @@ Improvement::
 
 * Upgrade to JRuby 9.4.3.0 (#1235) (@headius)
 
+Bug Fixes::
+
+* CLI should set :mkdirs option by default (#1241) (@mojavelinux)
+
 == 2.5.10 (2023-06-04)
 
 Improvement::

diff --git a/asciidoctorj-core/src/main/java/org/asciidoctor/jruby/cli/AsciidoctorInvoker.java b/asciidoctorj-core/src/main/java/org/asciidoctor/jruby/cli/AsciidoctorInvoker.java
@@ -160,6 +160,8 @@ private void convertInput(Asciidoctor asciidoctor, Options options, List<File> i
             return;
         }
 
+        options.setMkDirs(true);
+
         findInvalidInputFile(inputFiles)
                 .ifPresent(inputFile -> {
                     System.err.println("asciidoctor: FAILED: input file(s) '"

diff --git a/...doctorj-core/src/test/java/org/asciidoctor/jruby/cli/WhenAsciidoctorIsCalledUsingCli.java b/...doctorj-core/src/test/java/org/asciidoctor/jruby/cli/WhenAsciidoctorIsCalledUsingCli.java
@@ -20,6 +20,8 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.core.StringStartsWith.startsWith;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 @RunWith(Arquillian.class)
 public class WhenAsciidoctorIsCalledUsingCli {
@@ -277,6 +279,22 @@ public void with_absolute_path_file_should_be_rendered() {
         expectedFile.delete();
     }
 
+    @Test
+    public void should_create_targetdir() {
+
+        File inputFile = classpath.getResource("relative/sub/test.adoc");
+        File srcDir = inputFile.getParentFile().getParentFile(); // points to relative/
+        File toDir = new File(temporaryFolder.getRoot(), getClass().getSimpleName());
+        File expectedFile = new File(toDir, "test.html");
+        assertFalse(toDir.exists());
+
+        new AsciidoctorInvoker().invoke("-R", srcDir.getPath(), "-D", toDir.getPath(), srcDir.getAbsolutePath() + "/sub/test.adoc");
+        // Note that the subdirectory /sub is ignored, other than what asciidoctor does with it.
+
+        assertTrue(expectedFile.exists());
+        expectedFile.delete();
+    }
+
     private ByteArrayOutputStream redirectStdout() {
         ByteArrayOutputStream output = new ByteArrayOutputStream();
         System.setOut(new PrintStream(output));

diff --git a/asciidoctorj-core/src/test/resources/relative/sub/test.adoc b/asciidoctorj-core/src/test/resources/relative/sub/test.adoc
@@ -0,0 +1,5 @@
+= Test
+
+ == Test
+
+ Test