Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Java11 as minimal version for main branch (v3.0.x) #1150

Closed
abelsromero opened this issue Mar 21, 2023 · 1 comment · Fixed by #1151
Closed

Set Java11 as minimal version for main branch (v3.0.x) #1150

abelsromero opened this issue Mar 21, 2023 · 1 comment · Fixed by #1151
Labels
enhancement infrastructure

Comments

@abelsromero
Copy link
Member

abelsromero commented Mar 21, 2023 •
edited

Java8 is EOL and support for it is preventing some interesting constructs from being used in the code (e.g. immutable Maps).
It also requires extra CI time.
@robertpanzer
Copy link
Member

Makes a lot of sense to me.

abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 22, 2023
@abelsromero
Set Java11 as minimal version
0835ffd 
* Remove use of 'task.options.release' for Java version configuration in
in favour of Gradle's preferrs 'toolchain'.
* Removed Java 8 from pipelines.
* Bump Gradle to latest v8.0.2
* Remove use of 'io.spring.dependency-management' Gradle plugin in
'spring-boot' app in favor of Gradle's BOM support. This reduces
maintenance since only Boot version needs to be updated.

Fixes asciidoctor#1150
@abelsromero abelsromero mentioned this issue Mar 22, 2023
Merged
5 tasks
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 22, 2023
@abelsromero
Set Java11 as minimal version
75b048b 
* Remove use of 'task.options.release' for Java version configuration
in favour of Gradle's preferrs 'toolchain'.
* Removed Java 8 from pipelines.
* Bump Gradle to latest v8.0.2
* Remove use of 'io.spring.dependency-management' Gradle plugin in
'spring-boot' app in favor of Gradle's BOM support. This reduces
maintenance since only Boot version needs to be updated.

Fixes asciidoctor#1150
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 22, 2023
@abelsromero
Set Java11 as minimal version
38e22bc 
* Remove use of 'task.options.release' for Java version configuration
in favour of Gradle's preferrs 'toolchain'.
* Removed Java 8 from pipelines.
* Bump Gradle to latest v8.0.2
* Remove use of 'io.spring.dependency-management' Gradle plugin in
'spring-boot' app in favor of Gradle's BOM support. This reduces
maintenance since only Boot version needs to be updated.

Fixes asciidoctor#1150
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 22, 2023
@abelsromero
Set Java11 as minimal version
24ee694 
* Remove use of 'task.options.release' for Java version configuration
in favour of Gradle's preferrs 'toolchain'.
* Removed Java 8 from pipelines.
* Bump Gradle to latest v8.0.2
* Remove use of 'io.spring.dependency-management' Gradle plugin in
'spring-boot' app in favor of Gradle's BOM support. This reduces
maintenance since only Boot version needs to be updated.

Fixes asciidoctor#1150

Remove unnecessary configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set Java11 as minimal version abelsromero/asciidoctorj
2 participants
@robertpanzer @abelsromero