Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods from Asciidoctor interface #1201

Closed
abelsromero opened this issue May 20, 2023 · 0 comments · Fixed by #1207
Closed

Remove deprecated methods from Asciidoctor interface #1201

abelsromero opened this issue May 20, 2023 · 0 comments · Fixed by #1207
Labels
documentation enhancement
Milestone
v3.0.0

Comments

@abelsromero
Copy link
Member

abelsromero commented May 20, 2023 •
edited
Loading

Methods already marked should be removed for v3.0.0 release.
Those are:

  • Methods that use OptionsBuilder or Map<String,?> for options instead of Options instance
  • readDocumentHeader methods, that are replaced by load

We'll need to document these changes in the migration guide.
@abelsromero abelsromero added this to the v3.0.0 milestone May 20, 2023
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 21, 2023
@abelsromero
Remove deprecated methods from Asciidoctor interface
83e5514 
* Also remove class org.asciidoctor.ast.DocumentHeader

Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 21, 2023
@abelsromero
v3 migration guide for 'Asciidoctor' removed methods
cc65280 
Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 21, 2023
@abelsromero
Remove deprecated methods from Asciidoctor interface
63dcdba 
* Also remove class org.asciidoctor.ast.DocumentHeader
* Update changelog

Fixes asciidoctor#1201

Update changelog
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 21, 2023
@abelsromero
v3 migration guide for 'Asciidoctor' removed methods
2b96db9 
Fixes asciidoctor#1201
@abelsromero abelsromero mentioned this issue May 21, 2023
Merged
5 tasks
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 21, 2023
@abelsromero
Remove deprecated methods from Asciidoctor interface
050b4e4 
* Also remove class org.asciidoctor.ast.DocumentHeader
* Update changelog

Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 21, 2023
@abelsromero
v3 migration guide for 'Asciidoctor' removed methods
5b20ad4 
Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 22, 2023
@abelsromero
v3 migration guide for 'Asciidoctor' removed methods
9241818 
Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 29, 2023
@abelsromero
Remove deprecated methods from Asciidoctor interface
afd6d59 
* Also remove class org.asciidoctor.ast.DocumentHeader
* Update changelog

Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 29, 2023
@abelsromero
v3 migration guide for 'Asciidoctor' removed methods
fbd2838 
Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 29, 2023
@abelsromero
Remove deprecated methods from Asciidoctor interface
8f043e8 
* Also remove class org.asciidoctor.ast.DocumentHeader
* Update changelog

Fixes asciidoctor#1201
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 29, 2023
@abelsromero
v3 migration guide for 'Asciidoctor' removed methods
c1ea3b4 
Fixes asciidoctor#1201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated from Asciidoctor interface abelsromero/asciidoctorj
1 participant
@abelsromero