Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsciidoctorJ PDF fails on Windows since 1.5.0-alpha.10 #416

Closed
antoinesd opened this issue Jan 7, 2016 · 11 comments
Closed

AsciidoctorJ PDF fails on Windows since 1.5.0-alpha.10 #416

antoinesd opened this issue Jan 7, 2016 · 11 comments

Comments

@antoinesd
Copy link

My co-author and I are using Asciidoctor Maven plugin and Asciidoctorj-pdf to generate html and pdf version of our book.

I'm working on MacOS and had no problem to upgrade to Asciidoctor Maven plugin 1.5.3 and AsciidoctorJ 1.5.0-alpha.11.

My co-author is using windows 10 and have the following crash when generating pdf with these versions:

Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.5.3:process-asciidoc (generate-pdf-doc) on project book:
Execution generate-pdf-doc of goal org.asciidoctor:asciidoctor-maven-plugin:1.5.3:process-asciidoc failed:
(Errno::ENOENT) D:/maven/repository/org/asciidoctor/asciidoctorj-pdf/1.5.0-alpha.10.1/asciidoctorj-pdf-1.5.0-alpha.10.1.jar!D:/gems/addressable-2.3.8/data/unicode.data -> [Help 1]

When reverting to Mvn plugin 1.5.2.1 and AsciidoctorJ 1.5.0-alpha.9 generation is ok.

I reproduced the problem on windows 8.1 VM on my machine.
I'm not sure if it comes from Maven plugin or AsciidoctorJ. Sorry if I'm in the wrong place.

@robertpanzer
Copy link
Member

Hi Antoine,

I think you are seeing this issue with JRuby 1.7.23 on Windows: jruby/jruby#3496

I hope that it works if you go back to the version used by asciidoctorj, 1.7.21.
That is, please configure the asciidoctor-maven-plugin like this:

            <plugin>
                <groupId>org.asciidoctor</groupId>
                <artifactId>asciidoctor-maven-plugin</artifactId>
                <version>1.5.3</version>
                <dependencies>
                    <dependency>
                        <groupId>org.asciidoctor</groupId>
                        <artifactId>asciidoctorj-pdf</artifactId>
                        <version>1.5.0-alpha.10.1</version>
                    </dependency>
                    <dependency>
                        <groupId>org.jruby</groupId>
                        <artifactId>jruby-complete</artifactId>
                        <version>1.7.21</version>
                    </dependency>
                </dependencies>
                <configuration>
                    <backend>pdf</backend>
                </configuration>
            </plugin>

As there are new versions available of asciidoctor and asciidoctor-pdf you might even want to upgrade to the new versions:

            <plugin>
                <groupId>org.asciidoctor</groupId>
                <artifactId>asciidoctor-maven-plugin</artifactId>
                <version>1.5.3</version>
                <dependencies>
                    <dependency>
                        <groupId>org.asciidoctor</groupId>
                        <artifactId>asciidoctorj</artifactId>
                        <version>1.5.4</version>
                    </dependency>
                    <dependency>
                        <groupId>org.asciidoctor</groupId>
                        <artifactId>asciidoctorj-pdf</artifactId>
                        <version>1.5.0-alpha.11</version>
                    </dependency>
                    <dependency>
                        <groupId>org.jruby</groupId>
                        <artifactId>jruby-complete</artifactId>
                        <version>1.7.21</version>
                    </dependency>
                </dependencies>
                <configuration>
                    <backend>pdf</backend>
                </configuration>
            </plugin>

Cheers
Robert

@abelsromero
Copy link
Member

I guess we should revert the maven-plugin to 1.7.21 too until the issue is fixed.

Also, I just noticed the example uses v 9.0.4.0 and works fine.

@robertpanzer
Copy link
Member

Hi Abel,

I would recommend sticking with 1.7.21 at the moment.
Unfortunately JRuby doesn't have very much luck at the moment on Windows and also 9.0.4.0 has its issues: jruby/jruby#3473

Upgrading the JRuby dependency should rather be an option if you know you're not going to run on Windows instead of requiring to downgrade.

Cheers
Robert

@antoinesd
Copy link
Author

Hi Robert,
Reverting to JRuby 1.7.21 worked. Thanks a lot for your help.

@mojavelinux
Copy link
Member

That's good news.

We really need to let the JRuby folks know that the lack of Windows testing is really presenting quite a problem for the community.

On the other hand, we could do a better job of testing on Windows so that we pick JRuby versions that work :) Let's be sure to not just upgrade for upgrade sake.

@mojavelinux mojavelinux changed the title AsciidcotorJ PDF fails on Windows since 1.5.0-alpha.10 AsciidoctorJ PDF fails on Windows since 1.5.0-alpha.10 Jan 10, 2016
@robertpanzer
Copy link
Member

I think we can close this issue, as it was related to the asciidoctor-maven-plugin.

@abelsromero
Copy link
Member

It's been already fixed for the new release (asciidoctor/asciidoctor-maven-plugin#191)

@robertpanzer
Copy link
Member

👍

Am Montag, 11. Januar 2016 schrieb Abel Salgado Romero :

It's been already fixed for the new release (
asciidoctor/asciidoctor-maven-plugin#191
asciidoctor/asciidoctor-maven-plugin#191)


Reply to this email directly or view it on GitHub
#416 (comment)
.

@slaskawi
Copy link

Hey!

Could you please tell me when do you plan a release with this fix?

Thanks!
Sebastian

@abelsromero
Copy link
Member

The fix updates the jruby version used by default, but you can just replace it in your pom adding the dependency in the plugin configuration.
Here is an example:
https://github.com/asciidoctor/asciidoctor-maven-examples/blob/master/asciidoc-to-html-example/pom.xml#L27-L31

@slaskawi
Copy link

Thanks @abelsromero! Fortunately Windows builds are not top priority for us so we can just wait for another version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants