Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the CONTEXT_ prefix used by constants in Contexts annotation #569

Closed
mojavelinux opened this issue Aug 6, 2017 · 1 comment
Closed

Drop the CONTEXT_ prefix used by constants in Contexts annotation #569

mojavelinux opened this issue Aug 6, 2017 · 1 comment

Comments

@mojavelinux
Copy link
Member

I don't think the CONTEXT_ prefix is needed for the names of constants in the Contexts annotation. To me, it's already understood that we're talking about a context. Thus, the names should be like:

Contexts.OPEN

If there's a reason for the CONTEXT_ prefix, then I think it should be documented in the interface so the reason is clear.
@mojavelinux mojavelinux changed the title Drop the CONTEXT_ prefix in constants in Contexts annotation Drop the CONTEXT_ prefix on constants in Contexts annotation Aug 6, 2017
@mojavelinux mojavelinux changed the title Drop the CONTEXT_ prefix on constants in Contexts annotation Drop the CONTEXT_ prefix used by constants in Contexts annotation Aug 6, 2017
robertpanzer added a commit to robertpanzer/asciidoctorj that referenced this issue Aug 10, 2017
@robertpanzer
Fix asciidoctor#569 Remove leading CONTEXT prefix from all constants in
43334b7 
@contexts
@robertpanzer robertpanzer mentioned this issue Aug 10, 2017
Merged
robertpanzer added a commit that referenced this issue Aug 12, 2017
@robertpanzer
Fix #569 Remove leading CONTEXT prefix from all constants in @contexts (
c4581fb 
#571)
@robertpanzer
Copy link
Member

I think we can close this issue.
The PR was shipped with v1.6.0-alpha.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mojavelinux @robertpanzer