Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try lifting to Gradle 7.0 #1001

Merged
merged 6 commits into from
Mar 28, 2021
Merged

Conversation

robertpanzer
Copy link
Member

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

This PR tries to bring the build to Gradle 7.0.
I can't tell if the dependency declarations are all correct, the new scopes are still a mystery right now (I didn't spend much time yet digging into them)
Except the wildfly integration test everything seems to run on OSX.

@abelsromero Could you please check if this works on your machine? I've seen your issue yesterday and made an attempt myself today.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

@abelsromero
Copy link
Member

abelsromero commented Mar 24, 2021

Worked fine for me on Linux and MacOS. Thanks!!

@robertpanzer
Copy link
Member Author

Thanks! And the CI build also worked with Java 16 now.
I guess we can look at the wildfly test later, that seems to be a Java/Gradle problem rather than an AsciidoctorJ problem.

@robertpanzer
Copy link
Member Author

I'll check the poms tomorrow if they are still correct.

@abelsromero
Copy link
Member

Running locally I see Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private java.security.ProtectionDomain[] java.security.AccessControlContext.context accessible: module java.base does not "opens java.security" to unnamed module @18b9aa90with is to be expected with Java 16. Probably something wildfly team is already aware.

@robertpanzer
Copy link
Member Author

I managed to fix the Wildfly integration test.
Apparently I have been doing not enough JavaEE & Arquillian development lately, stupid me.

Also upgraded Gradle to 7.0-rc-1.

The generated poms are mostly identical now to the previous version, only the dependency for jcommander has changed from compile to runtime. I think this is fine since this library is only used for the CLI.

@robertpanzer
Copy link
Member Author

Stupid me, I was running with a wrong Java version, Wildfly still fails on Java 16.
Excluded it for no only for Java 16.

@abelsromero
Copy link
Member

abelsromero commented Mar 28, 2021

I got it working on my Linux machine.
Your changes gave me the idea the issue may be on the Arquillian side, just updated versions and added a RH repo required (don't ask me why)

ext {
    arquillianVersion = '1.6.0.Final'
    arquillianWildflyVersion = '3.0.1.Final'

    wildflyVersion = '23.0.0.Final'
}

repositories {
    maven {
        url "https://maven.repository.redhat.com/ga/"
    }
}

Furthermore, this runs without adding any extra Java16 condition to the build scripts.

@robertpanzer
Copy link
Member Author

Great find!
Do you want to create a PR? Then I'd merge mine now and merge yours on top.

@robertpanzer robertpanzer merged commit ab3dd19 into asciidoctor:master Mar 28, 2021
@robertpanzer robertpanzer deleted the gradle-7.0 branch March 28, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants