Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Wildfly IT with Java16 #1002

Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Mar 28, 2021

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?
Run asciidoctorj-wildfly-integration-test with Java16

How does it achieve that?
The fix only requires upgrading dependencies to latests

    arquillianVersion = '1.6.0.Final'
    arquillianWildflyVersion = '3.0.1.Final'

And addind the repo https://maven.repository.redhat.com/ga/, without it, build fails unable to collect certan specific dependencies.

Are there any alternative ways to implement this?
Tried different version to see if the extra maven repo could be removed without much luck. A part form that, not much alternatives to test.

Are there any implications of this pull request? Anything a user must know?
No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1000

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

@robertpanzer
Copy link
Member

Are these new files in the spring boot integration test necessary?
Or would it make sense to ignore them to .gitignore?

@abelsromero abelsromero force-pushed the fix/run-wildfly-test-with-java16 branch from ccd3466 to 46fc935 Compare March 28, 2021 16:27
@abelsromero
Copy link
Member Author

Are these new files in the spring boot integration test necessary?
Or would it make sense to ignore them to .gitignore?

Obviously not 🙄 fixed

@abelsromero
Copy link
Member Author

All green and without the onlyIf, we are safe then.

@robertpanzer robertpanzer merged commit 5a62279 into asciidoctor:master Mar 28, 2021
@robertpanzer
Copy link
Member

Awesome! Thank you!🍻🎉🚀

@abelsromero abelsromero deleted the fix/run-wildfly-test-with-java16 branch December 23, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project does not build with Java 16
2 participants